Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

runtime: Patch google cloud function #2494

Merged
merged 15 commits into from
Nov 12, 2020
Merged

Conversation

Benzbeeb
Copy link
Contributor

Implementation details

Patch google cloud function runtime

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested review from sorawit and taobun August 18, 2020 08:51
@render
Copy link

render bot commented Aug 18, 2020

@Benzbeeb Benzbeeb force-pushed the patch-google-cloud-function branch from 2f9b9d1 to 1f57b95 Compare August 18, 2020 08:54
@Benzbeeb Benzbeeb force-pushed the patch-google-cloud-function branch from fa2944c to aa17af6 Compare August 21, 2020 12:45
@Benzbeeb Benzbeeb requested a review from taobun August 21, 2020 12:46
runtime/Makefile Outdated
gcf:
cp $(CURRENT_DIR)/google-cloud-functions/google_cloud_function.py $(CURRENT_DIR)/google-cloud-functions/google_cloud_function.bak
cp $(CURRENT_DIR)/google-cloud-functions/main.py $(CURRENT_DIR)/google-cloud-functions/main.bak
mv $(CURRENT_DIR)/google-cloud-functions/google_cloud_function.py $(CURRENT_DIR)/google-cloud-functions/main.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't to copy requirements.txt from this directory like lambda?
Did zip can run requestsor ccxr package?

@Benzbeeb Benzbeeb force-pushed the patch-google-cloud-function branch from cfc1304 to fe78c00 Compare November 9, 2020 07:27
@Benzbeeb Benzbeeb force-pushed the patch-google-cloud-function branch from b68e8c7 to 77d3e05 Compare November 12, 2020 03:25
@taobun taobun merged commit 775e034 into master Nov 12, 2020
@taobun taobun deleted the patch-google-cloud-function branch November 12, 2020 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants