Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade quartz dependency #489

Conversation

kalaiyarasiganeshalingam
Copy link
Contributor

Purpose

$Subject

Fixes: https://github.com/wso2-enterprise/internal-support-ballerina/issues/437

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (685d24d) 90.37% compared to head (32414d8) 90.37%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #489   +/-   ##
=========================================
  Coverage     90.37%   90.37%           
  Complexity       92       92           
=========================================
  Files            12       12           
  Lines           343      343           
  Branches         56       56           
=========================================
  Hits            310      310           
  Misses           29       29           
  Partials          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi
Copy link
Contributor

Can we use rc1 dependencies in our libs?

@kalaiyarasiganeshalingam
Copy link
Contributor Author

kalaiyarasiganeshalingam commented Aug 31, 2023

Can we use rc1 dependencies in our libs?

We are using 2.3.2. Quartz's next major version lib hasn't been released yet. Updated versions are in RC, and the issue suggests the version in RC as well.
https://mvnrepository.com/artifact/org.quartz-scheduler/quartz

@daneshk @keizer619 Please give your suggestion.

@daneshk
Copy link
Member

daneshk commented Aug 31, 2023

Can we use rc1 dependencies in our libs?

We are using 2.3.2. Quartz's next major version lib hasn't been released yet. Updated versions are in RC, and the issue suggests the version in RC as well. https://mvnrepository.com/artifact/org.quartz-scheduler/quartz

@daneshk @keizer619 Please give your suggestion.

According to the quartz issue thread[1], this vulnerability does impact only if we expose the connection factory to be configured by the user. otherwise, there is no way to be vulnerable to the issue. They are still discussing whether it should handled at the application level. IMO, we are not impacted by this. and we can't go with rc1 release.

  1. API misuse of org.quartz.jobs.ee.jms.SendQueueMessageJob.execute would lead the code injection vulnerability. quartz-scheduler/quartz#943

@dilanSachi
Copy link
Contributor

According to the quartz issue thread[1], this vulnerability does impact only if we expose the connection factory to be configured by the user. otherwise, there is no way to be vulnerable to the issue. They are still discussing whether it should handled at the application level. IMO, we are not impacted by this. and we can't go with rc1 release.

  1. There's a code injection vulnerability of org.quartz.jobs.ee.jms.SendQueueMessageJob.execute quartz-scheduler/quartz#943

If we are not impacted, i guess we can ignore the vulnerability since we cannot use rc1 builds as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants