Deprecate getInitializationOptions() API and fix other deprecated usages

[NipunaRanasinghe]

Purpose

$subject.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

• Unit tests

  Code coverage information

• Integration tests

  Details about the test cases and coverage

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
• Ran FindSecurityBugs plugin and verified report? yes/no
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

[NipunaRanasinghe]

@payne911 Appreciate your review on this

[payne911]

No problem. :)
I'm glad to see you're deprecating that other method. I had thought about it when making that other PR but then thought backward compatibility is generally appreciated by users.

[payne911]

@payne911 Appreciate your review on this

Sorry, I just got back from vacation. It seems like this PR is merged now, but I still wanted to apologize. 👍

[mondhs]

I might be missing here something...
Today I pulled master, build lsp4intellij jar and added to my project.
I got yellow icon and my plugin was not working.
After analysis I found that with this pull request was changed LanguageServerWrapper#getInitParams().

It was removed:

initParams.setRootUri(FileUtils.pathToUri(projectRootPath));

but later in same method is used:

serverDefinition.getInitializationOptions(URI.create(initParams.getRootUri()))

Acodring javadoc URI.create this should cause always NPE .

I removed the URI.create code, rebuild everything and my plugin started working. Should I create pull new pull request with removing the line?