Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent null pointer exception with languageServerWrapper when opening / closing files #289

Conversation

bd-johnam
Copy link
Contributor

Purpose

fix for #288

Goals

prevent null pointer exception that occurs when opening / closing files

Approach

null check on LanguageServerWrapper

Test environment

OSX

@bd-johnam
Copy link
Contributor Author

@NipunaRanasinghe if you have sometime to review my latest Pull requests it would be appreciated, thanks!

@NipunaRanasinghe
Copy link
Contributor

@NipunaRanasinghe if you have sometime to review my latest Pull requests it would be appreciated, thanks!

@johnamSyn Sure I'll make sure to get them merged.

BTW could you please let us know if there any other fixes waiting from your side, so that we can wait a bit more before triggering a patch release with the current fixes?

@NipunaRanasinghe NipunaRanasinghe merged commit 366a0bd into ballerina-platform:master Feb 3, 2023
@bd-johnam
Copy link
Contributor Author

@NipunaRanasinghe I will open one more ticket today with PR after that one is merged I think I will be done on my side

@NipunaRanasinghe
Copy link
Contributor

@NipunaRanasinghe I will open one more ticket today with PR after that one is merged I think I will be done on my side

Sounds great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants