Add proper shutdown support when closing IDE window #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nipuna hold this off i need to do some more testing. I think i should only stop if its only running. Now we try to stop the same server twice 😔. My bad i didn't check the stop method frankly before pushing this change. Late night mistakes 😒 |
|
Hey no worries @gayanper! Take your time and let me know when your PR is ready :) may be you can do some more debugging to see whats really going wrong with the shutdown request |
This also fixes some exception which are thrown when server listener is used.
|
Cleanup the code and add more fixes to stop exception when a server listener is used. |
|
@NipunaRanasinghe you can review now |
|
@NipunaRanasinghe any update on this PR ? |
NipunaRanasinghe
approved these changes
Sep 23, 2019
|
@gayanper Thanks for the improvements :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for shutting down language server when IDE window is closed and IDEA jvm is forcefully stopped.