minor: add secureboot to device-config endpoint #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16fd615 to
9f8e855
Compare
Page-
reviewed
Feb 25, 2025
| 'secureboot', | ||
| )?.toString(); | ||
| if (['true', 'on', '1'].includes(securebootInstaller || '')) { | ||
| config.installer = { secureboot: true }; |
There was a problem hiding this comment.
I've checked the fibery link but I don't see where it's documented that the format should be
{ installer: { secureboot: true } }Do you know where I would confirm that format is correct?
There was a problem hiding this comment.
From our secureboot blog post where we ask the user to manually add that to the config.json:
https://blog.balena.io/balenaos-secure-boot-and-disk-encryption-for-x86-64/
There should be some more docs in an OS repo, I'm looking for them.
There was a problem hiding this comment.
Page-
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provision device with secureboot, we need the config.json to contain the secureboot installer entry.