Logs: add support for a start parameter when reading logs
#1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43e002c to
6d6353e
Compare
Change-type: patch
This can either be an ISO date or a milliseconds timestamp Change-type: minor
pipex
reviewed
Feb 18, 2025
thgreasi
reviewed
Feb 18, 2025
| @@ -189,6 +190,7 @@ export class LokiBackend implements DeviceLogsBackend { | |||
| query: this.getDeviceQuery(ctx), | |||
| limit: Number.isFinite(count) ? count : 1000, | |||
| since: '30d', | |||
| ...(start != null ? { start: `${BigInt(start) * 1000000n}` } : {}), | |||
There was a problem hiding this comment.
should this be v ?
Suggested change
| ...(start != null ? { start: `${BigInt(start) * 1000000n}` } : {}), | |
| ...(typeof start === 'number' ? { start: `${BigInt(start) * 1000000n}` } : {}), |
There was a problem hiding this comment.
It's either undefined or a number, so both checks should be equivalent?
thgreasi
reviewed
Feb 18, 2025
| @@ -225,5 +228,31 @@ export default () => { | |||
| 'streamed log line 1', | |||
| ]); | |||
| }); | |||
|
|
|||
| for (const fn of ['toISOString', 'getTime'] as const) { | |||
thgreasi
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://balena.fibery.io/Work/Project/Device-logs-Allow-specifying-a-start-date-when-fetching-logs-1164