Add stale lockfile removal mechanism for confd critical sections #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
August 22, 2024 15:27
Pull request was converted to draft
6015e11 to
4c48cfc
Compare
On underpowered machines, services may get terminated on healthcheck failures and leave behind stale lockfiles. This mechanism should mitigate this, by removing lock files older than 5m (300s), configurable. change-type: patch
4c48cfc to
552e70a
Compare
joshbwlng
reviewed
Jan 15, 2025
joshbwlng
reviewed
Jan 15, 2025
Co-authored-by: Josh Bowling <45343541+joshbwlng@users.noreply.github.com>
joshbwlng
reviewed
Jan 17, 2025
| remove_update_lock | ||
| return 0 | ||
| fi | ||
| return 1 |
There was a problem hiding this comment.
What's the reasoning for returning 1 here? I thought even in bash script returning anything other than 0 indicates an error.
joshbwlng
reviewed
Jan 17, 2025
| function set_update_lock { | ||
| if [[ -d "$(dirname "${CONF}")" ]]; then | ||
| echo "create lockfile ${CONF}.lock with ${LOCK_TIMEOUT}s age timeout" |
There was a problem hiding this comment.
Suggested change
| echo "create lockfile ${CONF}.lock with ${LOCK_TIMEOUT}s age timeout" | |
| echo "creating lockfile ${CONF}.lock with ${LOCK_TIMEOUT}s age timeout" |
Nit just to match the other log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/balena-io/balena-cloud/pull/3466
On underpowered machines, services may get terminated on healthcheck failures (and OOMs) and leave behind stale lockfiles. This mechanism should mitigate this, by removing lock files older than 5m (300s), configurable.
Only affects BoB(s) as this locking mechanism isn't used in production/Kubernetes.
change-type: patch