Skip to content

Commit

Permalink
Fixes tektoncd#1253. TestSidecarTaskSupport e2e test case fixed for c…
Browse files Browse the repository at this point in the history
…ustom base image
  • Loading branch information
bahetiamit committed Oct 9, 2020
1 parent e2f528b commit 455724b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/sidecar_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestSidecarTaskSupport(t *testing.T) {
}{{
desc: "A sidecar that runs forever is terminated when Steps complete",
stepCommand: []string{"echo", "\"hello world\""},
sidecarCommand: []string{"sh", "-c", "while [[ true ]] ; do echo \"hello from sidecar\" ; done"},
sidecarCommand: []string{"sh", "-c", "while [[ true ]] ; do echo \"hello from sidecar\" ; [[ -f /ko-app/nop ]] && break; done; ./ko-app/nop"},
}, {
desc: "A sidecar that terminates early does not cause problems running Steps",
stepCommand: []string{"echo", "\"hello world\""},
Expand Down

0 comments on commit 455724b

Please sign in to comment.