fix HF repo name issue when pushing

bagustris · May 29, 2024 · 4dc252b · 4dc252b
1 parent 8d72dd6
commit 4dc252b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/nkululeko/experiment.py b/nkululeko/experiment.py
@@ -73,8 +73,9 @@ def store_report(self):
         if self.util.config_val("REPORT", "latex", False):
             self.report.export_latex()
 
-    def get_name(self):
-        return self.util.get_exp_name()
+    # moved to util
+    # def get_name(self):
+    #     return self.util.get_exp_name()
 
     def set_globals(self, config_obj):
         """install a config object in the global space"""

diff --git a/nkululeko/models/model_tuned.py b/nkululeko/models/model_tuned.py
@@ -270,6 +270,7 @@ def compute_loss(
             remove_unused_columns=False,
             report_to="none",
             push_to_hub=push,
+            hub_model_id=f"{self.util.get_name()}",
         )
 
         trainer = Trainer(

diff --git a/nkululeko/utils/util.py b/nkululeko/utils/util.py
@@ -134,6 +134,12 @@ def is_categorical(self, pd_series):
             pd_series.dtype, pd.CategoricalDtype
         )
 
+    def get_name(self):
+        """
+        Get the name of the experiment
+        """
+        return self.config["EXP"]["name"]
+
     def get_exp_dir(self):
         """
         Get the experiment directory