Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add mobile dragging functionality #16

Merged
merged 6 commits into from
Nov 13, 2024
Merged

feat: Add mobile dragging functionality #16

merged 6 commits into from
Nov 13, 2024

Conversation

22JH
Copy link
Contributor

@22JH 22JH commented Nov 4, 2024 •
edited
Loading

feature

  • Add mobile touch events
  • Add blur event at ProseMirror on mobile (to prevent keyboard from popping up)
  • Adjust dot size for mobile (from 10px to 16px)
  • Adjust dot position for mobile (from -4px to -10px)

bae-sh
bae-sh reviewed Nov 7, 2024
View reviewed changes
Copy link
Owner

@bae-sh bae-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! The mobile feature looks fantastic. One small thing—could you fetch the latest changes and apply the Prettier configuration to match printWidth: 100?Appreciate your help!

lib/imageResize.ts Outdated Show resolved Hide resolved
@22JH 22JH requested a review from bae-sh November 11, 2024 05:06
@bae-sh bae-sh merged commit e1f8e01 into bae-sh:main Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bae-sh bae-sh Awaiting requested review from bae-sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@22JH @bae-sh