Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Liberapay logo #1692

Merged
merged 4 commits into from
May 18, 2018
Merged

Add Liberapay logo #1692

merged 4 commits into from
May 18, 2018

Conversation

mattbk
Copy link
Contributor

@mattbk mattbk commented May 16, 2018

Add optional logo for Liberapay badges.

Part of liberapay/liberapay.com#1103.

  • Please ensure your contribution follows our guidance for logo submissions.

@shields-ci
Copy link

shields-ci commented May 16, 2018

Messages
📖

✨ Thanks for your contribution to Shields, @mattbk!

📖

🎨 Thanks for submitting a logo. Please ensure your contribution follows our guidance for logo submissions.

Generated by 🚫 dangerJS

@RedSparr0w
Copy link
Member

Thanks for submitting this PR!
👍

Could you remove the extra background elements from the 2nd and 3rd logos,
And also run them through something like svgomg.

I'm not sure how we would be wanting to go about merging multiple logos variants, maybe @paulmelnikow has some ideas about this?

On that note though, i would be fine with just merging the 3rd logo for now () until we get more info on adding the extra variants:
(liberapay3.svgliberapay.svg) Could either update this PR or open a secondary PR

Examples:
Logo1:

Logo2:

Logo3:

@mattbk
Copy link
Contributor Author

mattbk commented May 18, 2018

It's a work in progress. I'm running the variants by people at liberapay/liberapay.com#1103 to pick just one.

@mattbk mattbk changed the title WIP Add liberapay logo Add Liberapay logo May 18, 2018
@mattbk
Copy link
Contributor Author

mattbk commented May 18, 2018

SVG has been optimized and variants removed. Ready for review.

@RedSparr0w
Copy link
Member

Thanks for the changes,
Logo looks good to me:

Merged!
👍

@RedSparr0w RedSparr0w merged commit 37617c1 into badges:master May 18, 2018
@fliiiix
Copy link

fliiiix commented May 19, 2018

@mattbk big thank you! do you know how long it usually takes until these badges are online?

@RedSparr0w
Copy link
Member

RedSparr0w commented May 19, 2018

do you know how long it usually takes until these badges are online?

Quoting @paulmelnikow:

Deploys usually happen every 1–3 weeks. Thaddée [@espadrine], who has limited time on this project, is the only sysadmin. He's working on giving me access to deploy and logs, but doing so is complicated because the hosting account (and maybe the servers too) are shared with other services he runs.

Edit: it has been almost 2 months since the last commit (Mar 25) so i'm hoping there will be one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants