Correctly set willBeRetried in messages

This fixes #849 [1]. [1] #849
badeball · Mar 19, 2023 · b5ce7af · b5ce7af
1 parent 3e638aa
commit b5ce7af
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file.
 
+## Unreleased
+
+- Correctly set `willBeRetried` in messages reports, fixes [#849](https://github.com/badeball/cypress-cucumber-preprocessor/issues/849).
+
 ## v15.1.5
 
 - Correctly escape injected values to glob patterns, fixes [#946](https://github.com/badeball/cypress-cucumber-preprocessor/issues/946).

diff --git a/features/fixtures/retried.ndjson b/features/fixtures/retried.ndjson
@@ -7,7 +7,7 @@
 {"testCaseStarted":{"id":"id","testCaseId":"id","attempt":0,"timestamp":{"seconds":0,"nanos":0}}}
 {"testStepStarted":{"testStepId":"id","testCaseStartedId":"id","timestamp":{"seconds":0,"nanos":0}}}
 {"testStepFinished":{"testStepId":"id","testCaseStartedId":"id","testStepResult":{"status":"FAILED","message":"some error","duration":0},"timestamp":{"seconds":0,"nanos":0}}}
-{"testCaseFinished":{"testCaseStartedId":"id","timestamp":{"seconds":0,"nanos":0},"willBeRetried":false}}
+{"testCaseFinished":{"testCaseStartedId":"id","timestamp":{"seconds":0,"nanos":0},"willBeRetried":true}}
 {"testCaseStarted":{"id":"id","testCaseId":"id","attempt":1,"timestamp":{"seconds":0,"nanos":0}}}
 {"testStepStarted":{"testStepId":"id","testCaseStartedId":"id","timestamp":{"seconds":0,"nanos":0}}}
 {"testStepFinished":{"testStepId":"id","testCaseStartedId":"id","testStepResult":{"status":"PASSED","duration":0},"timestamp":{"seconds":0,"nanos":0}}}

diff --git a/lib/create-tests.ts b/lib/create-tests.ts
@@ -808,11 +808,21 @@ export default function createTests(
       }
     }
 
+    const currentRetry = assertAndReturn(
+      (this.currentTest as any)?._currentRetry,
+      "Expected to find an attribute _currentRetry"
+    );
+
+    const retries = assertAndReturn(
+      (this.currentTest as any)?._retries,
+      "Expected to find an attribute _retries"
+    );
+
     messages.push({
       testCaseFinished: {
         testCaseStartedId,
         timestamp: endTimestamp,
-        willBeRetried: false,
+        willBeRetried: currentRetry < retries,
       },
     });