forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add PR template (autowarefoundation#82)
* ci(template): add pr template Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * ci(template): update to current usage Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
- Loading branch information
1 parent
f21814d
commit ede45b0
Showing
1 changed file
with
49 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
## Related Issue(required) | ||
|
||
<!-- Link related issue --> | ||
|
||
## Description(required) | ||
|
||
<!-- Describe what this PR changes. --> | ||
|
||
## Review Procedure(required) | ||
|
||
<!-- Explain how to review this PR. --> | ||
|
||
## Related PR(optional) | ||
|
||
<!-- Link related PR --> | ||
|
||
## Pre-Review Checklist for the PR Author | ||
|
||
**PR Author should check the checkboxes below when creating the PR.** | ||
|
||
- [ ] Read [commit-guidelines][commit-guidelines] | ||
- [ ] Assign PR to reviewer | ||
|
||
If you are adding new package following items are required: | ||
|
||
- [ ] Documentation with description of the package is available | ||
- [ ] A sample launch file and parameter file are available if the package contains executable nodes | ||
|
||
## Checklist for the PR Reviewer | ||
|
||
**Reviewers should check the checkboxes below before approval.** | ||
|
||
- [ ] Commits are properly organized and messages are according to the guideline | ||
- [ ] PR title describes the changes | ||
|
||
## Post-Review Checklist for the PR Author | ||
|
||
**PR Author should check the checkboxes below before merging.** | ||
|
||
- [ ] All open points are addressed and tracked via issues or tickets | ||
|
||
## CI Checks | ||
|
||
- **Build and test for PR / build-and-test-pr**: Required to pass before the merge. | ||
- **Build and test for PR / clang-tidy-pr**: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines]. | ||
- **Check spelling**: NOT required to pass before the merge. It is up to the reviewer(s). See [here][spell-check-dict] if you want to add some words to the spell check dictionary. | ||
|
||
[commit-guidelines]: https://www.conventionalcommits.org/en/v1.0.0/ | ||
[spell-check-dict]: https://github.com/tier4/autoware-spell-check-dict#how-to-contribute |