fixing simple things like removing unused code and imports before I t… #260
Annotations
78 warnings
|
missing documentation for a method:
src/skalo/utils.rs#L126
warning: missing documentation for a method
--> src/skalo/utils.rs:126:5
|
126 | pub fn get_range(&self, start: usize, end: usize) -> Vec<u8> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a method:
src/skalo/utils.rs#L122
warning: missing documentation for a method
--> src/skalo/utils.rs:122:5
|
122 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a method:
src/skalo/utils.rs#L96
warning: missing documentation for a method
--> src/skalo/utils.rs:96:5
|
96 | pub fn decode(&self) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/skalo/utils.rs#L60
warning: missing documentation for an associated function
--> src/skalo/utils.rs:60:5
|
60 | pub fn encode(dna: &str) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L55
warning: missing documentation for a struct field
--> src/skalo/utils.rs:55:5
|
55 | pub original_length: usize,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L54
warning: missing documentation for a struct field
--> src/skalo/utils.rs:54:5
|
54 | pub data: Vec<u8>,
| ^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/skalo/utils.rs#L46
warning: missing documentation for an associated function
--> src/skalo/utils.rs:46:5
|
46 | pub fn new(sequence: DnaSequence, vec_snps: Vec<usize>) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L42
warning: missing documentation for a struct field
--> src/skalo/utils.rs:42:5
|
42 | pub vec_snps: Vec<usize>,
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L41
warning: missing documentation for a struct field
--> src/skalo/utils.rs:41:5
|
41 | pub sequence: DnaSequence,
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/utils.rs#L40
warning: missing documentation for a struct
--> src/skalo/utils.rs:40:1
|
40 | pub struct VariantInfo {
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/utils.rs#L26
warning: missing documentation for a function
--> src/skalo/utils.rs:26:1
|
26 | pub fn rev_compl(seq: &str) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a static:
src/skalo/utils.rs#L24
warning: missing documentation for a static
--> src/skalo/utils.rs:24:1
|
24 | pub static DATA_INFO: OnceLock<DataInfo> = OnceLock::new();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L22
warning: missing documentation for a struct field
--> src/skalo/utils.rs:22:5
|
22 | pub sample_names: Vec<String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L21
warning: missing documentation for a struct field
--> src/skalo/utils.rs:21:5
|
21 | pub k_graph: usize,
| ^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/utils.rs#L20
warning: missing documentation for a struct
--> src/skalo/utils.rs:20:1
|
20 | pub struct DataInfo {
| ^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a static:
src/skalo/utils.rs#L16
warning: missing documentation for a static
--> src/skalo/utils.rs:16:1
|
16 | pub static CONFIG: OnceLock<Config> = OnceLock::new();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L14
warning: missing documentation for a struct field
--> src/skalo/utils.rs:14:5
|
14 | pub reference_genome: Option<PathBuf>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L13
warning: missing documentation for a struct field
--> src/skalo/utils.rs:13:5
|
13 | pub nb_threads: usize,
| ^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L12
warning: missing documentation for a struct field
--> src/skalo/utils.rs:12:5
|
12 | pub max_indel_kmers: usize,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L11
warning: missing documentation for a struct field
--> src/skalo/utils.rs:11:5
|
11 | pub max_depth: usize,
| ^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L10
warning: missing documentation for a struct field
--> src/skalo/utils.rs:10:5
|
10 | pub max_missing: f32,
| ^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L9
warning: missing documentation for a struct field
--> src/skalo/utils.rs:9:5
|
9 | pub output_name: String,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L8
warning: missing documentation for a struct field
--> src/skalo/utils.rs:8:5
|
8 | pub input_file: String,
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/utils.rs#L7
warning: missing documentation for a struct
--> src/skalo/utils.rs:7:1
|
7 | pub struct Config {
| ^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/read_graph.rs#L298
warning: missing documentation for a struct
--> src/skalo/read_graph.rs:298:1
|
298 | pub struct PathState<T> {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/read_graph.rs#L17
warning: missing documentation for a function
--> src/skalo/read_graph.rs:17:1
|
17 | / pub fn build_variant_groups<IntT: for<'a> UInt<'a>>(
18 | | mut all_kmers: HashMap<IntT, Vec<IntT>>,
19 | | start_kmers: HashSet<IntT>,
20 | | end_kmers: HashSet<IntT>,
... |
23 | | data_info: &DataInfo,
24 | | ) {
| |_^
|
|
bounds on generic parameters in type aliases are not enforced:
src/skalo/process_variants.rs#L9
warning: bounds on generic parameters in type aliases are not enforced
--> src/skalo/process_variants.rs:9:26
|
9 | type VariantGroups<IntT: for<'a> UInt<'a>> = HashMap<(IntT, IntT), Vec<VariantInfo>>;
| --^^^^^^^^^^^^^^^^
| | |
| | will not be checked at usage sites of the type alias
| help: remove this bound
|
= note: this is a known limitation of the type checker that may be lifted in a future edition.
see issue #112792 <https://github.com/rust-lang/rust/issues/112792> for more information
= help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics
= note: `#[warn(type_alias_bounds)]` on by default
|
|
missing documentation for a function:
src/skalo/input.rs#L14
warning: missing documentation for a function
--> src/skalo/input.rs:14:1
|
14 | / pub fn build_graph<IntT: for<'a> UInt<'a>>(
15 | | ska_array: MergeSkaArray<IntT>,
16 | | nb_threads: usize,
17 | | ) -> (usize, Vec<String>, KmerGraph<IntT>, KmerSamples<IntT>) {
| |_____________________________________________________________^
|
|
missing documentation for a function:
src/skalo/extremities.rs#L7
warning: missing documentation for a function
--> src/skalo/extremities.rs:7:1
|
7 | / pub fn identify_good_kmers<IntT: for<'a> UInt<'a>>(
8 | | all_kmers: &HashMap<IntT, Vec<IntT>>,
9 | | kmer_2_samples: &HashMap<IntT, BitSet>,
10 | | data_info: &DataInfo,
11 | | ) -> (HashSet<IntT>, HashSet<IntT>) {
| |___________________________________^
|
|
missing documentation for a module:
src/skalo/mod.rs#L8
warning: missing documentation for a module
--> src/skalo/mod.rs:8:1
|
8 | pub mod utils;
| ^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/skalo/mod.rs#L7
warning: missing documentation for a module
--> src/skalo/mod.rs:7:1
|
7 | pub mod read_graph;
| ^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/skalo/mod.rs#L3
warning: missing documentation for a module
--> src/skalo/mod.rs:3:1
|
3 | pub mod input;
| ^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/skalo/mod.rs#L2
warning: missing documentation for a module
--> src/skalo/mod.rs:2:1
|
2 | pub mod extremities;
| ^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/ska_dict/bit_encoding.rs#L127
warning: missing documentation for an associated function
--> src/ska_dict/bit_encoding.rs:127:5
|
127 | fn encode_vecu8(kmer: &[u8]) -> Option<Self>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/ska_dict/bit_encoding.rs#L125
warning: missing documentation for an associated function
--> src/ska_dict/bit_encoding.rs:125:5
|
125 | fn skalo_decode_kmer(encoded: Self, k: usize) -> String;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/ska_dict/bit_encoding.rs#L124
warning: missing documentation for an associated function
--> src/ska_dict/bit_encoding.rs:124:5
|
124 | fn get_last_nucl(encoded_kmer: Self) -> char;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/ska_dict/bit_encoding.rs#L123
warning: missing documentation for an associated function
--> src/ska_dict/bit_encoding.rs:123:5
|
123 | fn encode_u8_kmer(dna: &[u8]) -> Self;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/ska_dict/bit_encoding.rs#L122
warning: missing documentation for an associated function
--> src/ska_dict/bit_encoding.rs:122:5
|
122 | fn combine_kmers(encoded_kmer1: Self, encoded_kmer2: Self) -> Self;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/ska_dict/bit_encoding.rs#L121
warning: missing documentation for an associated function
--> src/ska_dict/bit_encoding.rs:121:5
|
121 | fn rev_compl(kmer: Self, k: usize) -> Self;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/lib.rs#L452
warning: missing documentation for a module
--> src/lib.rs:452:1
|
452 | pub mod skalo;
| ^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:424:9
|
424 | #![warn(missing_docs)]
| ^^^^^^^^^^^^
|
|
struct `DnaSequence` has a public `len` method, but no `is_empty` method:
src/skalo/utils.rs#L122
warning: struct `DnaSequence` has a public `len` method, but no `is_empty` method
--> src/skalo/utils.rs:122:5
|
122 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
src/merge_ska_array.rs#L628
warning: the following explicit lifetimes could be elided: 'a
--> src/merge_ska_array.rs:628:6
|
628 | impl<'a, IntT> Iterator for KmerIter<'a, IntT>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
628 - impl<'a, IntT> Iterator for KmerIter<'a, IntT>
628 + impl<IntT> Iterator for KmerIter<'_, IntT>
|
|
|
empty line after doc comment:
src/ska_ref.rs#L110
warning: empty line after doc comment
--> src/ska_ref.rs:110:5
|
110 | / /// Mapping information
111 | |
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
111 | ///
|
|
|
empty line after doc comment:
src/ska_ref.rs#L101
warning: empty line after doc comment
--> src/ska_ref.rs:101:5
|
101 | / /// Input sequence
102 | |
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
102 | ///
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
| |____________________________________^ help: consider parenthesizing your expression: `(1 << (key & 63)) | (1 << ((key >> 6) & 63))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63) | (1 << ((key >> 12) & 63))
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
66 | | | 1 << ((key >> 18) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63)
65 + | 1 << ((key >> 12) & 63) | (1 << ((key >> 18) & 63))
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
66 | | | 1 << ((key >> 18) & 63)
67 | | | 1 << ((key >> 24) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63)
65 + | 1 << ((key >> 12) & 63)
66 + | 1 << ((key >> 18) & 63) | (1 << ((key >> 24) & 63))
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L345
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:345:17
|
345 | self = (self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 64) & 0x0000000000000000FFFFFFFFFFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L345
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:345:16
|
345 | self = (self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF)
| ________________^
346 | | | (self & 0x0000000000000000FFFFFFFFFFFFFFFF) << 64;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF) | ((self & 0x0000000000000000FFFFFFFFFFFFFFFF) << 64)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L343
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:343:17
|
343 | self = (self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32) & 0x00000000FFFFFFFF00000000FFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L343
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:343:16
|
343 | self = (self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF)
| ________________^
344 | | | (self & 0x00000000FFFFFFFF00000000FFFFFFFF) << 32;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF) | ((self & 0x00000000FFFFFFFF00000000FFFFFFFF) << 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L341
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:341:17
|
341 | self = (self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16) & 0x0000FFFF0000FFFF0000FFFF0000FFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L341
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:341:16
|
341 | self = (self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF)
| ________________^
342 | | | (self & 0x0000FFFF0000FFFF0000FFFF0000FFFF) << 16;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF) | ((self & 0x0000FFFF0000FFFF0000FFFF0000FFFF) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L339
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:339:17
|
339 | self = (self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8) & 0x00FF00FF00FF00FF00FF00FF00FF00FF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L339
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:339:16
|
339 | self = (self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF)
| ________________^
340 | | | (self & 0x00FF00FF00FF00FF00FF00FF00FF00FF) << 8;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF) | ((self & 0x00FF00FF00FF00FF00FF00FF00FF00FF) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L337
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:337:17
|
337 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4) & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L337
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:337:16
|
337 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F)
| ________________^
338 | | | (self & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) << 4;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) | ((self & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L335
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:335:17
|
335 | self = (self >> 2 & 0x33333333333333333333333333333333)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2) & 0x33333333333333333333333333333333`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L335
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:335:16
|
335 | self = (self >> 2 & 0x33333333333333333333333333333333)
| ________________^
336 | | | (self & 0x33333333333333333333333333333333) << 2;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 2 & 0x33333333333333333333333333333333) | ((self & 0x33333333333333333333333333333333) << 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L147
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:147:17
|
147 | self = (self >> 32 & 0x00000000FFFFFFFF) | (self & 0x00000000FFFFFFFF) << 32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32) & 0x00000000FFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L147
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:147:16
|
147 | self = (self >> 32 & 0x00000000FFFFFFFF) | (self & 0x00000000FFFFFFFF) << 32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32 & 0x00000000FFFFFFFF) | ((self & 0x00000000FFFFFFFF) << 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L146
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:146:17
|
146 | self = (self >> 16 & 0x0000FFFF0000FFFF) | (self & 0x0000FFFF0000FFFF) << 16;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16) & 0x0000FFFF0000FFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L146
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:146:16
|
146 | self = (self >> 16 & 0x0000FFFF0000FFFF) | (self & 0x0000FFFF0000FFFF) << 16;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16 & 0x0000FFFF0000FFFF) | ((self & 0x0000FFFF0000FFFF) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L145
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:145:17
|
145 | self = (self >> 8 & 0x00FF00FF00FF00FF) | (self & 0x00FF00FF00FF00FF) << 8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8) & 0x00FF00FF00FF00FF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L145
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:145:16
|
145 | self = (self >> 8 & 0x00FF00FF00FF00FF) | (self & 0x00FF00FF00FF00FF) << 8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8 & 0x00FF00FF00FF00FF) | ((self & 0x00FF00FF00FF00FF) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L144
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:144:17
|
144 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F) | (self & 0x0F0F0F0F0F0F0F0F) << 4;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4) & 0x0F0F0F0F0F0F0F0F`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L144
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:144:16
|
144 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F) | (self & 0x0F0F0F0F0F0F0F0F) << 4;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4 & 0x0F0F0F0F0F0F0F0F) | ((self & 0x0F0F0F0F0F0F0F0F) << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L143
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:143:17
|
143 | self = (self >> 2 & 0x3333333333333333) | (self & 0x3333333333333333) << 2;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2) & 0x3333333333333333`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L143
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:143:16
|
143 | self = (self >> 2 & 0x3333333333333333) | (self & 0x3333333333333333) << 2;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2 & 0x3333333333333333) | ((self & 0x3333333333333333) << 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L210
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:210:34
|
210 | self.rc_upper = (self.rc_upper >> 2
| __________________________________^
211 | | | (IntT::from_encoded_base(rc_base(new_base))) << (2 * ((half_k * 2) - 1)))
| |______________________________________________________________________________________________^ help: consider parenthesizing your expression: `(self.rc_upper >> 2) | ((IntT::from_encoded_base(rc_base(new_base))) << (2 * ((half_k * 2) - 1)))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L206
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:206:34
|
206 | self.rc_lower = (self.rc_lower >> 2
| __________________________________^
207 | | | ((IntT::from_encoded_base(self.rc_middle_base)) << (2 * (half_k - 1))))
| |____________________________________________________________________________________________^ help: consider parenthesizing your expression: `(self.rc_lower >> 2) | ((IntT::from_encoded_base(self.rc_middle_base)) << (2 * (half_k - 1)))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L199
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:199:27
|
199 | self.upper = (self.upper << 2
| ___________________________^
200 | | | (IntT::from_encoded_base(self.middle_base) << (half_k * 2)))
| |_____________________________________________________________________________^ help: consider parenthesizing your expression: `(self.upper << 2) | (IntT::from_encoded_base(self.middle_base) << (half_k * 2))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
clippy_check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|