Merge pull request #89 from bacpop/covbuildmerge #273
Annotations
32 warnings
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
| |____________________________________^ help: consider parenthesizing your expression: `(1 << (key & 63)) | (1 << ((key >> 6) & 63))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63) | (1 << ((key >> 12) & 63))
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
66 | | | 1 << ((key >> 18) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63)
65 + | 1 << ((key >> 12) & 63) | (1 << ((key >> 18) & 63))
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
66 | | | 1 << ((key >> 18) & 63)
67 | | | 1 << ((key >> 24) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63)
65 + | 1 << ((key >> 12) & 63)
66 + | 1 << ((key >> 18) & 63) | (1 << ((key >> 24) & 63))
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L200
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:200:17
|
200 | self = (self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 64) & 0x0000000000000000FFFFFFFFFFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L200
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:200:16
|
200 | self = (self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF)
| ________________^
201 | | | (self & 0x0000000000000000FFFFFFFFFFFFFFFF) << 64;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF) | ((self & 0x0000000000000000FFFFFFFFFFFFFFFF) << 64)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L198
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:198:17
|
198 | self = (self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32) & 0x00000000FFFFFFFF00000000FFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L198
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:198:16
|
198 | self = (self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF)
| ________________^
199 | | | (self & 0x00000000FFFFFFFF00000000FFFFFFFF) << 32;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF) | ((self & 0x00000000FFFFFFFF00000000FFFFFFFF) << 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L196
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:196:17
|
196 | self = (self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16) & 0x0000FFFF0000FFFF0000FFFF0000FFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L196
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:196:16
|
196 | self = (self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF)
| ________________^
197 | | | (self & 0x0000FFFF0000FFFF0000FFFF0000FFFF) << 16;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF) | ((self & 0x0000FFFF0000FFFF0000FFFF0000FFFF) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L194
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:194:17
|
194 | self = (self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8) & 0x00FF00FF00FF00FF00FF00FF00FF00FF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L194
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:194:16
|
194 | self = (self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF)
| ________________^
195 | | | (self & 0x00FF00FF00FF00FF00FF00FF00FF00FF) << 8;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF) | ((self & 0x00FF00FF00FF00FF00FF00FF00FF00FF) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L192
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:192:17
|
192 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4) & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L192
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:192:16
|
192 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F)
| ________________^
193 | | | (self & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) << 4;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) | ((self & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L190
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:190:17
|
190 | self = (self >> 2 & 0x33333333333333333333333333333333)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2) & 0x33333333333333333333333333333333`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L190
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:190:16
|
190 | self = (self >> 2 & 0x33333333333333333333333333333333)
| ________________^
191 | | | (self & 0x33333333333333333333333333333333) << 2;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 2 & 0x33333333333333333333333333333333) | ((self & 0x33333333333333333333333333333333) << 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L136
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:136:17
|
136 | self = (self >> 32 & 0x00000000FFFFFFFF) | (self & 0x00000000FFFFFFFF) << 32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32) & 0x00000000FFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L136
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:136:16
|
136 | self = (self >> 32 & 0x00000000FFFFFFFF) | (self & 0x00000000FFFFFFFF) << 32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32 & 0x00000000FFFFFFFF) | ((self & 0x00000000FFFFFFFF) << 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L135
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:135:17
|
135 | self = (self >> 16 & 0x0000FFFF0000FFFF) | (self & 0x0000FFFF0000FFFF) << 16;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16) & 0x0000FFFF0000FFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L135
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:135:16
|
135 | self = (self >> 16 & 0x0000FFFF0000FFFF) | (self & 0x0000FFFF0000FFFF) << 16;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16 & 0x0000FFFF0000FFFF) | ((self & 0x0000FFFF0000FFFF) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L134
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:134:17
|
134 | self = (self >> 8 & 0x00FF00FF00FF00FF) | (self & 0x00FF00FF00FF00FF) << 8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8) & 0x00FF00FF00FF00FF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L134
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:134:16
|
134 | self = (self >> 8 & 0x00FF00FF00FF00FF) | (self & 0x00FF00FF00FF00FF) << 8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8 & 0x00FF00FF00FF00FF) | ((self & 0x00FF00FF00FF00FF) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L133
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:133:17
|
133 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F) | (self & 0x0F0F0F0F0F0F0F0F) << 4;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4) & 0x0F0F0F0F0F0F0F0F`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L133
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:133:16
|
133 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F) | (self & 0x0F0F0F0F0F0F0F0F) << 4;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4 & 0x0F0F0F0F0F0F0F0F) | ((self & 0x0F0F0F0F0F0F0F0F) << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L132
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:132:17
|
132 | self = (self >> 2 & 0x3333333333333333) | (self & 0x3333333333333333) << 2;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2) & 0x3333333333333333`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L132
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:132:16
|
132 | self = (self >> 2 & 0x3333333333333333) | (self & 0x3333333333333333) << 2;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2 & 0x3333333333333333) | ((self & 0x3333333333333333) << 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L210
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:210:34
|
210 | self.rc_upper = (self.rc_upper >> 2
| __________________________________^
211 | | | (IntT::from_encoded_base(rc_base(new_base))) << (2 * ((half_k * 2) - 1)))
| |______________________________________________________________________________________________^ help: consider parenthesizing your expression: `(self.rc_upper >> 2) | ((IntT::from_encoded_base(rc_base(new_base))) << (2 * ((half_k * 2) - 1)))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L206
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:206:34
|
206 | self.rc_lower = (self.rc_lower >> 2
| __________________________________^
207 | | | ((IntT::from_encoded_base(self.rc_middle_base)) << (2 * (half_k - 1))))
| |____________________________________________________________________________________________^ help: consider parenthesizing your expression: `(self.rc_lower >> 2) | ((IntT::from_encoded_base(self.rc_middle_base)) << (2 * (half_k - 1)))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L199
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:199:27
|
199 | self.upper = (self.upper << 2
| ___________________________^
200 | | | (IntT::from_encoded_base(self.middle_base) << (half_k * 2)))
| |_____________________________________________________________________________^ help: consider parenthesizing your expression: `(self.upper << 2) | (IntT::from_encoded_base(self.middle_base) << (half_k * 2))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
Rust project - latest (nightly)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Rust project - latest (stable)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Rust project - latest (beta)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|