Merge pull request #414 from backend-developers-ltd/cve-check-cleanup

Kill cve check process on timeout
backend-developers-ltd · Feb 13, 2025 · 13ce663 · 13ce663
2 parents cebd430 + de7e5df
commit 13ce663
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/executor/app/src/compute_horde_executor/executor/management/commands/run_executor.py b/executor/app/src/compute_horde_executor/executor/management/commands/run_executor.py
@@ -949,6 +949,7 @@ async def is_nvidia_toolkit_version_safe_cve_2024_0132(self):
                 process.communicate(), CVE_2024_0132_TIMEOUT_SECONDS
             )
         except TimeoutError:
+            process.kill()
             logger.error("NVIDIA Container Toolkit Version for CVE-2024-0132 check timed out")
             return False
 

diff --git a/executor/app/src/compute_horde_executor/executor/tests/integration/test_main_loop.py b/executor/app/src/compute_horde_executor/executor/tests/integration/test_main_loop.py
@@ -87,6 +87,7 @@ async def is_nvidia_toolkit_version_safe_cve_2024_0132(self):
             try:
                 stdout, stderr = await asyncio.wait_for(process.communicate(), 5)
             except TimeoutError:
+                process.kill()
                 is_toolkit_installed = False
 
         if is_toolkit_installed is None and process.returncode != 0: