Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add changelog for pr 91 #97

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

RafilxTenfen
Copy link
Contributor

Forgot to add changelog in #91

@RafilxTenfen RafilxTenfen self-assigned this Sep 26, 2024
@RafilxTenfen RafilxTenfen requested a review from a team as a code owner September 26, 2024 15:00
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it's a good idea to add CI check for changelog, or have a PR template with checklist?

@KonradStaniec
Copy link
Collaborator

osmosis have workflow to remaind about changelog - https://github.com/osmosis-labs/osmosis/blob/main/.github/workflows/changelog-entry-reminder.yml, unless pr have special label A:no-changelog. Maybe we should copy it ?

@RafilxTenfen RafilxTenfen merged commit da4cc46 into main Sep 27, 2024
19 checks passed
RafilxTenfen added a commit that referenced this pull request Sep 27, 2024
Forgot to add changelog in #91
@RafilxTenfen RafilxTenfen deleted the chore/changelog-from-91 branch January 17, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants