Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject forks if the first header is already known #445

Merged

Conversation

KonradStaniec
Copy link
Collaborator

Fixes: https://github.com/babylonlabs-io/pm/issues/159

We will reject BTC forks, if the first header is already known.

This is consensus breaking change, but on our testnet it should be non-breaking as our vigilante reporter always reports only new btc headers prefix/

@KonradStaniec KonradStaniec added the consensus breaking change modifies `appHash` of the application label Jan 27, 2025
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@KonradStaniec KonradStaniec force-pushed the konradstaniec/check-for-first-header-in-case-of-reorg branch from 0c0033e to 76a86fc Compare January 27, 2025 12:02
@KonradStaniec KonradStaniec merged commit 367f8c0 into main Jan 27, 2025
24 checks passed
@KonradStaniec KonradStaniec deleted the konradstaniec/check-for-first-header-in-case-of-reorg branch January 27, 2025 12:20
KonradStaniec added a commit that referenced this pull request Jan 27, 2025
Fixes: babylonlabs-io/pm#159

We will reject BTC forks, if the first header is already known.

This is consensus breaking change, but on our testnet it should be
non-breaking as our vigilante reporter always reports only new btc
headers prefix/
KonradStaniec added a commit that referenced this pull request Jan 28, 2025
Fixes: babylonlabs-io/pm#159

We will reject BTC forks, if the first header is already known.

This is consensus breaking change, but on our testnet it should be
non-breaking as our vigilante reporter always reports only new btc
headers prefix/
KonradStaniec added a commit that referenced this pull request Jan 28, 2025
Fixes: babylonlabs-io/pm#159

We will reject BTC forks, if the first header is already known.

This is consensus breaking change, but on our testnet it should be
non-breaking as our vigilante reporter always reports only new btc
headers prefix/
KonradStaniec added a commit that referenced this pull request Jan 28, 2025
)

Fixes: babylonlabs-io/pm#159

We will reject BTC forks, if the first header is already known.

This is consensus breaking change, but on our testnet it should be
non-breaking as our vigilante reporter always reports only new btc
headers prefix/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus breaking change modifies `appHash` of the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants