chore(adr-39): Refactor rewarding #360
Conversation
| // skip if finality provider didn't vote | ||
| if _, ok := voters[fp.BtcPk.MarshalHex()]; !ok { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Does this mean that the reward for unvoted FPs remains in the feeCollector account? For example, assuming 4 FPs with equal voting power, 3 of them voted for a block, and 1 did not. Then 3/4 of the reward in the reward gauge is distributed to the 3 FPs, whereas the rest 1/3 remains.
Is this expected or we want to distribute the whole reward to voted FPs?
There was a problem hiding this comment.
Good point. I didn't think of that. I think we should split all the rewards to the voted FPs but what happens if the rewards remain in the feeCollector account?
There was a problem hiding this comment.
I think we should split all the rewards to the voted FPs
Agree with that. We should split the rewards between all fps that voted on finalized block.
cbb211e to
f17d83e
Compare
f17d83e to
29c8150
Compare
Implements https://github.com/babylonlabs-io/pm/pull/145 including:
finality_sig_timeout