-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump SDK to 0.50.11 #353
Conversation
@@ -34,7 +34,7 @@ func magicHash(msg string) chainhash.Hash { | |||
return chainhash.DoubleHashH(bytes) | |||
} | |||
|
|||
func Sign(sk *btcec.PrivateKey, msg string) ([]byte, error) { | |||
func Sign(sk *btcec.PrivateKey, msg string) []byte { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SebastianElvis can you verify that this change does not lead to any issues? For example, we have to do other validity checks now instead of checking the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked btcec package and this modification is fine -- SignCompact
shall not return error anyway so they removed the returned error
@@ -34,7 +34,7 @@ func magicHash(msg string) chainhash.Hash { | |||
return chainhash.DoubleHashH(bytes) | |||
} | |||
|
|||
func Sign(sk *btcec.PrivateKey, msg string) ([]byte, error) { | |||
func Sign(sk *btcec.PrivateKey, msg string) []byte { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked btcec package and this modification is fine -- SignCompact
shall not return error anyway so they removed the returned error
This feels a bit hacky, and it might be better to have a separate repo for client package |
No description provided.