Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump SDK to 0.50.11 #353

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: Bump SDK to 0.50.11 #353

merged 1 commit into from
Jan 13, 2025

Conversation

vitsalis
Copy link
Member

No description provided.

@vitsalis vitsalis requested a review from a team as a code owner December 17, 2024 08:51
@vitsalis vitsalis requested review from Lazar955 and RafilxTenfen and removed request for a team December 17, 2024 08:51
@@ -34,7 +34,7 @@ func magicHash(msg string) chainhash.Hash {
return chainhash.DoubleHashH(bytes)
}

func Sign(sk *btcec.PrivateKey, msg string) ([]byte, error) {
func Sign(sk *btcec.PrivateKey, msg string) []byte {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianElvis can you verify that this change does not lead to any issues? For example, we have to do other validity checks now instead of checking the error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked btcec package and this modification is fine -- SignCompact shall not return error anyway so they removed the returned error

@@ -34,7 +34,7 @@ func magicHash(msg string) chainhash.Hash {
return chainhash.DoubleHashH(bytes)
}

func Sign(sk *btcec.PrivateKey, msg string) ([]byte, error) {
func Sign(sk *btcec.PrivateKey, msg string) []byte {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked btcec package and this modification is fine -- SignCompact shall not return error anyway so they removed the returned error

@Lazar955
Copy link
Member

This feels a bit hacky, and it might be better to have a separate repo for client package

@vitsalis vitsalis merged commit b2cdb43 into main Jan 13, 2025
21 checks passed
@vitsalis vitsalis deleted the sdk-0.50.11 branch January 13, 2025 13:03
vitsalis added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants