Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

andomnes commit replay test #344

Merged
merged 4 commits into from
Dec 16, 2024
Merged

andomnes commit replay test #344

merged 4 commits into from
Dec 16, 2024

Conversation

KonradStaniec
Copy link
Collaborator

  • Add fuzzing test case showing our jailing is non-deterministic now

@KonradStaniec KonradStaniec added the A:no-changelog changes that do not require changelog update label Dec 13, 2024
@KonradStaniec
Copy link
Collaborator Author

replay test shows that it is jailing that it is culprit of non-determinism. After #342 is merged this branch will be re-based on top of main, and then test should pass.

@gitferry gitferry mentioned this pull request Dec 13, 2024
Merged
gitferry
gitferry approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my local end with the non-determinism fix #342 and worked. Amazing work!

@KonradStaniec KonradStaniec force-pushed the konradstaniec/randomnes-commit-replay-test branch from c50dfb1 to d12dc02 Compare December 16, 2024 06:44
@KonradStaniec KonradStaniec marked this pull request as ready for review December 16, 2024 07:03
@KonradStaniec KonradStaniec requested a review from a team as a code owner December 16, 2024 07:03
@KonradStaniec KonradStaniec requested review from Lazar955 and samricotta and removed request for a team December 16, 2024 07:03
@KonradStaniec KonradStaniec merged commit 3cd871c into main Dec 16, 2024
19 checks passed
@KonradStaniec KonradStaniec deleted the konradstaniec/randomnes-commit-replay-test branch December 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitferry gitferry gitferry approved these changes

@Lazar955 Lazar955 Awaiting requested review from Lazar955 Lazar955 was automatically assigned from babylonlabs-io/core-dev

@samricotta samricotta Awaiting requested review from samricotta samricotta was automatically assigned from babylonlabs-io/core-dev

Assignees
No one assigned
Labels
A:no-changelog changes that do not require changelog update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonradStaniec @gitferry