fix error handling in checkpointing module #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c782e60 to
92a8583
Compare
Lazar955
approved these changes
Nov 8, 2024
gitferry
approved these changes
Nov 8, 2024
92a8583 to
5c07691
Compare
filippos47
pushed a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error handling in checkpointing module:
err = types.ErrInvalidCkptStatus.Wrapf("the status of the checkpoint should be %s", from.String())was just allocating error and not doing anything with itckptWithMeta, err := k.GetRawCheckpoint(ctx, epoch)was just getting swallowed