chore: Add logs to checking unbonding output #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwbabylonlab
approved these changes
Nov 5, 2024
| } | ||
|
|
||
| err = btcstaking.CheckSlashingTxMatchFundingTx( | ||
| pm.UnbondingSlashingTx.Transaction, | ||
| pm.UnbondingTx.Transaction, | ||
| unbondingOutputIdx, | ||
| 0, // unbonding output always has only 1 output |
There was a problem hiding this comment.
hmm if we are hardcoidng this, I feel than we should have a test case to assert that unbonding tx with more that 1 output are rejcected. Maybe in validate_parsed_message_test.go
There was a problem hiding this comment.
good point. Added this case in e2916de
d2ce1fc to
e2916de
Compare
KonradStaniec
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.