Allow choosing min_unbonding_time in the params as unbonding time
#263
Assignees
Labels
api breaking
breaks grpc api in non-compatible way
consensus breaking
change modifies `appHash` of the application
Comments
gitferry
added a commit
that referenced
this issue
Nov 20, 2024
Closes #263. In particular, - ensure `checkpointFinalizationTimeout` can never be changed in the update params handler of the btccheckpoint module - ensure `minUnbondingTime` can not be set to a value less than or equal to `checkpointFinalizationTimeout` in the update params handler of the btcstaking module - allows `unbondingTime` of a delegation to be set to a value equals to `minUnbondingTime`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the unbonding time in a delegation is checked by
unbonding_time > max(min_unbonding_time, checkpoint_finalization_timeout)which means the unbonding time must be higher thanmin_unbonding_time, which is not aligned with other min values in the params where inclusive value is allowed. This causes confusion for the frontend to show a valid unbonding time to the users.An ideal solution is to allow using a min value for the unbonding time and enforce the rule that
min_unbonding_time > checkpoint_finalization_timeout.The text was updated successfully, but these errors were encountered: