Skip to content

Commit

Permalink
Update automatic tag creation validation for Minor Version (#471)
Browse files Browse the repository at this point in the history
Till now we were considering a digit for tag for all versions. But it is possible that the minor version may go beyond 9, in that case the automatic tag creation workflow will fail at input tag validation step. This commit updates the validation to handle such cases

Signed-off-by: Shameem Ahmed shmeeh@amazon.com
  • Loading branch information
ahmed-shameem authored and ritanwar committed Nov 25, 2024
1 parent 6a6632a commit e14f7cc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/scripts/create-tag.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ fi

# check the tag format (need manual update when necessary)
format=BABEL_
if ! [[ "$new" =~ "$format"[0-9]_[0-9]_[0-9]__"PG"_[0-9]+_[0-9] ]]
if ! [[ "$new" =~ "$format"[0-9]_[0-9]+_[0-9]__"PG"_[0-9]+_[0-9]+ ]]
then
echo "Error: Invalid tag prefix, expected: ${format}<digit>_<digit>_<digit>__PG_<number>_<digit>"
echo "Error: Invalid tag prefix, expected: ${format}<digit>_<number>_<digit>__PG_<number>_<number>"
exit 1
fi

Expand Down

0 comments on commit e14f7cc

Please sign in to comment.