[OSS-ONLY] Restrict grant to/from any babelfish created role via PG port #3386
+14
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (OidIsValid(roleid) && IS_DEFAULT_BBF_SERVER_ROLE(rolename)) | ||
| if (OidIsValid(roleid) && is_babelfish_role(rolename)) | ||
| { | ||
| pfree(rolename); |
There was a problem hiding this comment.
We didn't palloc'd this object so shouldn't be free'ing it as well.
| @@ -973,7 +975,8 @@ is_babelfish_role(const char *role) | |||
| && OidIsValid(bbf_msdb_guest_oid) | |||
| && is_member_of_role(role_oid, bbf_master_guest_oid) | |||
| && is_member_of_role(role_oid, bbf_tempdb_guest_oid) | |||
| && is_member_of_role(role_oid, bbf_msdb_guest_oid)) | |||
| && is_member_of_role(role_oid, bbf_msdb_guest_oid) | |||
| && is_member_of_role(bbf_admin_oid, role_oid)) | |||
There was a problem hiding this comment.
What about only checking membership against bbf_role_admin? Is it sufficient or do we still need the above checks?
There was a problem hiding this comment.
Tried, that wasn't sufficient for a case where a TSQL user having sysadmin privilege was able to create/alter a user via PG port. Since TSQL user created the PG user, it was being considered as a BBF user and didn't get dropped.
Pull Request Test Coverage Report for Build 12685975063Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restrict grant to/from any babelfish created role via PG port
All server and database roles including fixed server roles and database roles have 'bbf_role_admin' as its member. Added a check to identify if 'bbf_role_admin' is a member of any role in addition to the existing checks to avoid granting any Babelfish db/server role to another Babelfish db/server roles including fixed db and server roles.
Issues Resolved
Task: BABEL-5505
Signed-off-by: Shalini Lohia lshalini@amazon.com
Test Scenarios Covered