Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4x] Minor fix for babel_index_nulls_order_before_15_5 test #3383

Conversation

xhfanhe
Copy link
Contributor

@xhfanhe xhfanhe commented Jan 8, 2025

Description

This commit fixes typo in babel_index_nulls_order_before_15_5 test.

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…-postgresql#3374)


This commit fixes typo in babel_index_nulls_order_before_15_5 test.

Signed-off-by: Xiaohui Fanhe <hexiaohu@amazon.com>
@xhfanhe xhfanhe changed the title Minor fix for babel_index_nulls_order_before_15_5 test [4x] Minor fix for babel_index_nulls_order_before_15_5 test Jan 8, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12680442480

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 74.922%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 2 76.03%
Totals Coverage Status
Change from base Build 12669927930: -0.002%
Covered Lines: 46905
Relevant Lines: 62605

💛 - Coveralls

@forestkeeper forestkeeper merged commit 0cc8f3b into babelfish-for-postgresql:BABEL_4_X_DEV Jan 9, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants