Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict grant to/from any babelfish created role #3382

Conversation

shalinilohia50
Copy link
Contributor

@shalinilohia50 shalinilohia50 commented Jan 8, 2025

Description

Block Granting Fixed DB Roles to another Fixed DB role via PG port.
All fixed server roles and database roles have 'bbf_role_admin' as its member. Added a check to identify if 'bbf_role_admin' is a member of any role in addition to the existing checks to avoid granting fixed db/server roles to another fixed db/server roles.

Issues Resolved

Task: BABEL-5505
Signed-off-by: Shalini Lohia lshalini@amazon.com

Test Scenarios Covered

  • Use case based -
  • Boundary conditions -
  • Arbitrary inputs -
  • Negative test cases -
  • Minor version upgrade tests -
  • Major version upgrade tests -
  • Performance tests -
  • Tooling impact -
  • Client tests -

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12683264327

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 57 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 74.89%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdsutils.c 57 72.6%
Totals Coverage Status
Change from base Build 12672066046: -0.008%
Covered Lines: 46667
Relevant Lines: 62314

💛 - Coveralls

@shalinilohia50 shalinilohia50 deleted the jira-5505-5stable branch January 9, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants