Adding windows user to db_owner role fails if user name has backslash (#3377) #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the following issues in the implementation of supporting adding of multiple users to db_owner role: - Name clash around internal db_owner role: We will now check if the internal role we are about to create already exists or not, if it does, we throw an error. Conversely, if a server/database principal exists with the same name as the internal role we are about to create, we will throw an appropriate error. - Extra rows for sp_helpuser: Added a check for RoleName column to only contain T-SQL roles. - Unable to make db_owner role schema owner: We will not change owner of schema if it's authorization lies with db_owner role. - Adding/dropping of valid users to db_owner role again should not throw error: During addition, if user is already member of db_owner, we will omit creating internal role. During drop, if user is not member of db_owner role, we will omit dropping the internal role. Task: BABEL-4899, BABEL-5491, BABEL-5502 Signed-off-by: Sharu Goel <goelshar@amazon.com>
…db_owner-fixes-5-x
…babelfish-for-postgresql#3377) Previously, if we create a user for windows login containing a backslash and add that user to db_owner role, we were throwing an error saying the internal role name is invalid. To fix this, we will not check for backslash for the internal role created when adding user db_owner role. Essentially, the check is redundant since we already check if a user is a valid user during create user and if user name has backslash and is not associated with windows login we will throw an error at create time itself. Task: BABEL-5539 Signed-off-by: Sharu Goel goelshar@amazon.com
Pull Request Test Coverage Report for Build 12670505059Details
💛 - Coveralls |
shalinilohia50
approved these changes
Jan 8, 2025
shardgupta
approved these changes
Jan 9, 2025
6b9598d
into
babelfish-for-postgresql:BABEL_5_X_DEV
45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if we create a user for windows login containing a
backslash and add that user to db_owner role, we were throwing an error
saying the internal role name is invalid.
To fix this, we will not check for backslash for the internal role
created when adding user db_owner role. Essentially, the check is
redundant since we already check if a user is a valid user during create
user and if user name has backslash and is not associated with windows
login we will throw an error at create time itself.
Task: BABEL-5539
Signed-off-by: Sharu Goel goelshar@amazon.com
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.