[OSS-ONLY] Update JDBC Framework to run under a single connection (#3240

)

With this commit we enforce JDBC framework to use and keep re-using only 1 connection through it's entirety. We enable this only for non-upgrade tests for now.
To do so we execute the sp_reset_connection after each test file, using the same connection object. In case of crossdialect files (.mix) we still keep reusing the the same connection unless the user has specified their own --tsql/--psql connections.
While enabling this we encountered a lot of bugs which we fixed and add explicit tests under Test-sp_reset_connection.mix but there are other issues that using one connections bring with it like the drawback of not able to unload pg_hint_plan from the current session and other bugs. To avoid them from failing we update these test files as .mix files with their own "--tsql" connection which gets disconnected at the end of the file.

Issues Resolved
BABEL-5255

Signed-off-by: Kushaal Shroff <kushaal@amazon.com>

.github/composite-actions/minor-version-upgrade-util/action.yml

@@ -81,7 +81,7 @@ runs:
         tar_dir: ${{ matrix.upgrade-path.last_version }}
       run: |
         cd test/JDBC/
-        export isUpgradeTestMode=false
+        export isUpgradeTestMode=true
         if [[ ${{ inputs.server_collation_name }} != "default" ]]; then
           export serverCollationName=${{ inputs.server_collation_name }}
         fi

.github/composite-actions/run-verify-tests/action.yml

@@ -41,7 +41,7 @@ runs:
         touch dummy_schedule
         echo "all" > dummy_schedule
         export scheduleFile=dummy_schedule
-        export isUpgradeTestMode=false
+        export isUpgradeTestMode=true
         if [[ ${{ inputs.server_collation_name }} != "default" ]]; then
           export serverCollationName=${{ inputs.server_collation_name }}
         fi

.github/composite-actions/setup-base-version/action.yml

@@ -210,7 +210,7 @@ runs:
             exit 1
           fi
         done
-        export isUpgradeTestMode=false
+        export isUpgradeTestMode=true
         export inputFilesPath=input
         for filename in $(grep -v "^ignore.*\|^#.*\|^cmd.*\|^all.*\|^$" upgrade/$base_dir/schedule); do
           sed -i "s/\b$filename[ ]*\b$/$filename-vu-prepare/g" upgrade/$base_dir/schedule

test/JDBC/expected/BABEL-2955-vu-cleanup.out

@@ -12,11 +12,3 @@ go
 
 drop table babel_2955_vu_prepare_t2
 go
-
-SELECT set_config('babelfishpg_tsql.escape_hatch_storage_options', 'ignore', 'false')
-go
-~~START~~
-text
-ignore
-~~END~~
-

test/JDBC/expected/BABEL-2955-vu-prepare.out

@@ -52,3 +52,11 @@ insert into babel_2955_vu_prepare_t2 values (1)
 GO
 ~~ROW COUNT: 1~~
 
+
+SELECT set_config('babelfishpg_tsql.escape_hatch_storage_options', 'ignore', 'false')
+go
+~~START~~
+text
+ignore
+~~END~~
+

test/JDBC/expected/BABEL-3156.out

@@ -127,15 +127,17 @@ int#!#varchar#!#int#!#nvarchar#!#smallint#!#tinyint#!#tinyint#!#int#!#varchar#!#
 ~~ERROR (Message: column "not_a_col" of relation "babel_3156" does not exist)~~
 
 
-
 exec sp_describe_undeclared_parameters
     N'UPDATE BABEL_3156 SET a=@P1 WHERE not_a_col=@P2';
-G
-DROP TABLE BABEL_3156;
 GO
+~~START~~
+int#!#varchar#!#int#!#nvarchar#!#smallint#!#tinyint#!#tinyint#!#int#!#varchar#!#varchar#!#varchar#!#nvarchar#!#int#!#varchar#!#varchar#!#varchar#!#bit#!#bit#!#bit#!#bit#!#bit#!#varchar#!#int#!#int
 ~~ERROR (Code: 33557097)~~
 
-~~ERROR (Message: syntax error near 'DROP' at line 4 and character position 0)~~
+~~ERROR (Message: column "not_a_col" of relation "babel_3156" does not exist)~~
+
 
+DROP TABLE BABEL_3156;
+GO
 DROP TABLE dbo.performancetable;
 GO

test/JDBC/expected/BABEL-3291.out

@@ -1,3 +1,4 @@
+-- tsql
 drop table if exists babel_3291_t1
 go
 

test/JDBC/expected/BABEL-3292.out

@@ -1,3 +1,4 @@
+-- tsql
 drop table if exists babel_3292_t1
 go
 

test/JDBC/expected/BABEL-3293.out

@@ -1,3 +1,4 @@
+-- tsql
 drop table if exists babel_3293_t1
 go
 

test/JDBC/expected/BABEL-3294.out

@@ -1,3 +1,4 @@
+-- tsql
 drop table if exists babel_3294_t1
 go
 

test/JDBC/expected/BABEL-3295.out

@@ -1,3 +1,4 @@
+-- tsql
 drop table if exists babel_3295_t1
 go
 

test/JDBC/expected/BABEL-3512.out

@@ -1,3 +1,4 @@
+-- tsql
 
 /*
  * Test stored procs WITH hints. All tests examine the query plan AND the 

test/JDBC/expected/BABEL-3592.out

@@ -1,3 +1,4 @@
+-- tsql
 drop procedure if exists babel_3592_insert_multiline
 go
 

test/JDBC/expected/BABEL-4294-vu-verify.out

@@ -1,3 +1,4 @@
+-- tsql
 
 -- Test to check if initialisation of Parallel Worker crash when babelfishpg_tsql.enable_pg_hint is set
 /*

test/JDBC/expected/babel_index_nulls_order-before-15-5-vu-verify.out

@@ -1,3 +1,4 @@
+-- tsql
 -- Nulls check
 SELECT * FROM babel_index_nulls_order_before_15_5_a_v1
 go

test/JDBC/expected/babel_index_nulls_order-vu-verify.out

@@ -1,3 +1,4 @@
+-- tsql
 -- Nulls check
 SELECT * FROM babel_index_nulls_order_a_v1
 go

test/JDBC/expected/linked_servers-vu-verify.out

@@ -1,3 +1,4 @@
+-- tsql
 -- Check if the linked server added is reflected in the system view
 SELECT name, product, provider, data_source, provider_string, catalog, is_linked FROM sys.servers WHERE name NOT LIKE 'bbf_server%' AND name NOT LIKE 'server_4229%' ORDER BY name
 GO

test/JDBC/expected/linked_srv_4229-vu-verify.out

@@ -1,3 +1,4 @@
+-- tsql
 -- Call OPENQUERY() / four-part-object name from a database other than master
 USE tempdb
 CREATE TABLE t_tempdb_babel_4229 (a int)