forked from pmndrs/jotai
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gru Tester] Add unit test for src/vanilla/utils/atomWithReset.ts #11
Open
gru-bot
wants to merge
1
commit into
gru-unit-test
Choose a base branch
from
gru-tester-src-vanilla-utils-atomWithReset-ts
base: gru-unit-test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Gru Tester] Add unit test for src/vanilla/utils/atomWithReset.ts #11
gru-bot
wants to merge
1
commit into
gru-unit-test
from
gru-tester-src-vanilla-utils-atomWithReset-ts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@coderabbitai full review |
vangie
approved these changes
Sep 27, 2024
vangie
reviewed
Sep 27, 2024
Comment on lines
+1
to
+16
/* eslint-disable @typescript-eslint/no-explicit-any */ | ||
/* eslint-disable @typescript-eslint/no-unused-vars */ | ||
/* eslint-disable @typescript-eslint/no-explicit-any */ | ||
/* eslint-disable @typescript-eslint/no-unused-vars */ | ||
import { beforeEach, describe, expect, it, vi } from 'vitest' | ||
import { atom } from '../../vanilla.ts' | ||
import { atomWithReset } from './atomWithReset.ts' | ||
import { RESET } from './constants.ts' | ||
|
||
vi.mock('../../vanilla.ts', async (importOriginal) => { | ||
const actual = await importOriginal<typeof import('../../vanilla.ts')>() | ||
return { | ||
...actual, | ||
atom: vi.fn(actual.atom), | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/* eslint-disable @typescript-eslint/no-explicit-any */ | |
/* eslint-disable @typescript-eslint/no-unused-vars */ | |
/* eslint-disable @typescript-eslint/no-explicit-any */ | |
/* eslint-disable @typescript-eslint/no-unused-vars */ | |
import { beforeEach, describe, expect, it, vi } from 'vitest' | |
import { atom } from '../../vanilla.ts' | |
import { atomWithReset } from './atomWithReset.ts' | |
import { RESET } from './constants.ts' | |
vi.mock('../../vanilla.ts', async (importOriginal) => { | |
const actual = await importOriginal<typeof import('../../vanilla.ts')>() | |
return { | |
...actual, | |
atom: vi.fn(actual.atom), | |
} | |
}) | |
import { beforeEach, describe, expect, it, vi } from 'vitest' | |
import { RESET, atomWithReset } from 'jotai/vanilla/utils' | |
vi.mock('jotai/vanilla', async (importOriginal) => { | |
const actual = await importOriginal<typeof import('jotai/vanilla')>() | |
return { | |
...actual, | |
atom: vi.fn(actual.atom), | |
} | |
}) |
最终过 lint 的代码是这样的。我们在这个项目里 lint 似乎没有开启。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Score (skipped)
0
Source Code
Link
Value & Challenge
Value Detail
Challenge Detail
Coverage
The change in coverage value, such as:
0% -> 50%
, indicates that the coverage was 0% before writing the tests and 50% after writing them.https://web.dev/articles/ta-code-coverage
Langsmith Link
Link
Step writeAndRunTest Overview
Last Model Result
Pre
Exec
npx vitest run /jotai/src/vanilla/utils/atomWithReset.gru.test.ts (0)
Post
pnpm test:format (0)
pnpm test:types (0)
pnpm test:lint (0)