Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update some dependencies #2671

Merged
merged 8 commits into from
Aug 31, 2022
Merged

chore: update some dependencies #2671

merged 8 commits into from
Aug 31, 2022

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Aug 28, 2022

webpack doesn't work on newer versions of nodejs.

@netlify
Copy link

netlify bot commented Aug 28, 2022

Deploy Preview for babel ready!

Name Link
🔨 Latest commit 9ef01f4
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/630eb0eeb01cac00096d73a6
😎 Deploy Preview https://deploy-preview-2671--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@liuxingbaoyu liuxingbaoyu changed the title chore chore: update some dependencies Aug 28, 2022
@liuxingbaoyu liuxingbaoyu marked this pull request as ready for review August 28, 2022 20:09
@liuxingbaoyu
Copy link
Member Author

This seems to require upgrading the yarn1 version in the netlify environment variable settings. Can you help me?
cc @JLHwung @nicolo-ribaudo

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if you keep .yarnrc? I guess older Yarn 1 versions, like 1.13 used in netlify build images, only supports .yarnrc.

@liuxingbaoyu
Copy link
Member Author

It doesn't seem possible, due to the old version of node.
The default yarn version has been updated, except that it defaults to the version when the project was created.
I guess we can update them together in environment variables.

https://answers.netlify.com/t/default-yarn-version-is-now-1-17/2297/11

@JLHwung
Copy link
Contributor

JLHwung commented Aug 30, 2022

@liuxingbaoyu I have added YARN_VERSION=1.22.19 environment variable, can you push a new commit? I can't re-run the netlify checks from GitHub UI.

This reverts commit 160e944.
@liuxingbaoyu
Copy link
Member Author

It looks like we also need to update the NODE version as yarn3 dropped NODE10 support.

@JLHwung
Copy link
Contributor

JLHwung commented Aug 30, 2022

https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript

Can you create .node-version at the project root? We can stay with latest until the build is broken.

@liuxingbaoyu
Copy link
Member Author

Yarn is working fine now, there are other errors, I will continue to investigate.

@liuxingbaoyu
Copy link
Member Author

https://docs.netlify.com/configure-builds/troubleshooting-tips/#build-cache
I can't find the reason at all, can you try this?

@JLHwung
Copy link
Contributor

JLHwung commented Aug 31, 2022

@liuxingbaoyu The test was passing (but failing on CI) probably because our local filesystems are not case-sensitive. ./node_modules/Buffer and ./node_modules/buffer both works.

@liuxingbaoyu
Copy link
Member Author

Amazing, thanks!

@JLHwung JLHwung merged commit fb72c00 into babel:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants