Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move assumptions docs to a normal docs page #2503

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Move assumptions docs to a normal docs page #2503

merged 3 commits into from
Apr 19, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 16, 2021 •
edited
Loading

By moving them to a normal docs page we:

  • Can add it to the sidebar
  • Get the right sidebar with links to the various assumptions automatically
  • Have /docs in the page URL

Preview: https://deploy-preview-2503--babel.netlify.app/docs/en/assumptions

@netlify
Copy link

netlify bot commented Apr 16, 2021 •
edited
Loading

Deploy preview for babel ready!

Built with commit 60af619

https://deploy-preview-2503--babel.netlify.app

hzoo
hzoo approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@JLHwung JLHwung merged commit 3ed2520 into master Apr 19, 2021
@JLHwung JLHwung deleted the move-assumptions branch April 19, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolo-ribaudo @hzoo @JLHwung