-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the gsoc blog post #1279
Add the gsoc blog post #1279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small minor nits, but awesome work @peey! 👍
_posts/2017-07-02-gsoc-peey-1.md
Outdated
aware of the whole issue, the discussion surrounding it, and have familiarity | ||
with the part of the codebase that the PR makes changes to.<sup><a href="#footnotes">1</a></sup> | ||
|
||
When I initially joined Babel, and was not-so-familiar with the codebase, every |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and that everyone’s expected to adhere to the same fictitious standards
_posts/2017-07-02-gsoc-peey-1.md
Outdated
In open source, there are a lot of people who want to contribute, but are unable | ||
to because they don’t know how to code / they don’t know how to present PRs / | ||
they don’t know what the project wants / they don’t know what the maintainers | ||
want / a ton of other things. A lot of the times you’ll find help along the way, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of
thetimes you’ll find help along the way
_posts/2017-07-02-gsoc-peey-1.md
Outdated
forward. And doing that by somehow identifying what the project needs and being | ||
able to deliver that. | ||
|
||
In order to merge this PR I had find people and talk to them — people who use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to merge this PR I had to find people
also, babel -> Babel
spec and all the existing discussions surrounding
_posts/2017-07-02-gsoc-peey-1.md
Outdated
And that’s what did it! (or so I think). So there’s the mystery unraveled — A PR | ||
with unusually high number of reviews¹. | ||
|
||
**PS**: I wanted to share my personal experience experience with this blog post, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: extra experience
_posts/2017-07-02-gsoc-peey-1.md
Outdated
|
||
Also note that if you’re looking for decorators support in Babel, we still have | ||
a long way to go. This is just the parser and work on the transform (which | ||
converts your code to functionally equivalent ES5)is yet to be done. But now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space between ES5)is
_posts/2017-07-02-gsoc-peey-1.md
Outdated
notes](https://github.com/babel/notes/blob/master/2017-06/june-21.md#priority-topics)). | ||
Perhaps you could help us with this. Drop by [our slack | ||
chatroom](https://slack.babeljs.io/) and offer your help! | ||
2. I feel that the myth stems from the fact that when you’re new to the project the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so
at the end seems extraneous?
we should mention somewhere that you are part of gsoc (you can ignore the ci fail, looks like a lot of random remark errors). (I should just write up a blogpost about how we are participating in that actually) |
@existentialism fixed those! @hzoo : added that info. Also decided to run it through Grammarly and found that I've been using too many commas which aren't needed. I hope they can stay, because when I wrote this I was using them as conversation pauses! |
Deploy preview ready! Built with commit cc04f11 |
This is failing lint, which is breaking the Travis build. Could you please fix it?
|
From medium: https://medium.com/@peey/personal-experiences-at-babel-1-a-pr-with-unusually-high-number-of-reviews-5cb49ee71897
cc @hzoo