-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouping elements in navbar #1073
Conversation
- name: Packages | ||
items: | ||
- title: API | ||
url: /docs/core-packages/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API
is pointing babel's core packages. We can rename it if you want.
As an alternative to the indention, what are your thoughts about: Also, I think renaming "API" -> "Core" under Packages is a little clearer? @hzoo? Otherwise, LGTM! |
Yes, Looks better. Have you tried with the collasped version ? |
Yeah, we can do something similar for now... when we attack the sidebar we may have to rethink a bunch of this anyway: |
It seems great 👍. Would you push it there so we can merge this. |
@xtuc pushed changes, check em out |
Nice job, thanks! LGTM, can we merge this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Awesome looks good. Although now I think maybe would could rename a few things? Should core be babel-core and polyfill babel-polyfill or is the shorthand better? Maybe should remove the browser in usage since it redirects to setup anyway? |
Good point re: browsers, agree we should drop. And yeah, while I think Core and Polyfill look better, it might be better to go with babel-core and babel-polyfill to eliminate any chance someone might be confused (esp since babel-register is below, and Register would be pretty strange by itself). I'll update! |
Fixes #1060
Desktop:
Collasped:
Given #1042 this is a quick fix.
Navigation data has a bit changed: