Don't add '.js' extension if the source file doesn't have an extension #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have in my current project a
binfolder containing executable files without any extension, and I ran into the issue where these files were renamed with a.jsextension after going through gulp-babel when I wished they could remain extensionless.I've made a quick change to fix this but, as it causes a change of behaviour, this might possibly break for some users that relied on this feature for their executable files.
To keep backward compatibility, a new option could be added, possibly accepting globs as values, that would allow to filter which files are to be renamed to
.js, and that would come with a default value preserving the current behaviour. I could have modified theoptsparameter in this purpose but didn't dare doing so since it should remain dedicated to Babel but maybe adding a second parameter to gulp-babel could do?Let me know!
Kind regards.