B7 alpha #112
Merged
B7 alpha #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
commented
Mar 24, 2017
test.js
Outdated
| @@ -108,7 +108,7 @@ it('should list used helpers in file.babel', function (cb) { | |||
|
|
|||
| it('should not rename ignored files', function (cb) { | |||
| var stream = babel({ | |||
| ignore: /fixture/ | |||
| ignore: [/fixture/] | |||
There was a problem hiding this comment.
breaking change in babel-core was requiring ignore to be an array
hzoo
commented
Mar 24, 2017
| res.map.file = replaceExtension(res.map.file); | ||
| applySourceMap(file, res.map); | ||
| } | ||
| if (res !== null) { |
There was a problem hiding this comment.
breaking change is that ignored files return null?
There was a problem hiding this comment.
Yes, some user may want to access code of null.
hzoo
commented
Mar 24, 2017
index.js
Outdated
| @@ -26,7 +25,7 @@ module.exports = function (opts) { | |||
| } | |||
|
|
|||
| try { | |||
| var fileOpts = objectAssign({}, opts, { | |||
| var fileOpts = Object.assign({}, opts, { | |||
There was a problem hiding this comment.
dropping node 0.10/0.12 so removing this for native
Merged
loganfsmyth
reviewed
Mar 27, 2017
| file.contents = new Buffer(res.code); | ||
| file.path = replaceExtension(file.path); | ||
| } | ||
| if (!res.ignored) { |
There was a problem hiding this comment.
I don't think we need this if since the null check does this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess also v7.0.0-alpha.3?