This repository has been archived by the owner on May 19, 2018. It is now read-only.
Small fix for parsing type parameter declarations #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you eat a token, it looks like Babylon automatically lexes the next token. Setting
this.state.inType
changes the behavior of the lexer, so it needs to be set before eating the type. This was causing trouble, sincewouldn't parse, since we would eat the
=
token before settingthis.state.inType = true
, which meantvoid
was lexed as an expression instead as a type.However, the whole type parameter declaration should be parsed with
this.state.inType = true
anyway. Sometimes it was, like for functions and arrow functions, but often it was not. This change makes all type parameter declarations be parsed withthis.state.inType = true
.