This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix lookahead to not add comments to arrays which are not cloned #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not clone arrays in lookahead() but comments were added to leading/trailing arrays during lookahead, leading to leak to the next next() call. Also extracted parsing of JSXSpreadChild to own parse function.
Current coverage is 96.69%
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not clone arrays in lookahead() but comments are added to the leading/trailing arrays during lookahead. The next next() call would then add the comments again, leading to this comments being in this arrays twice.
This was showing as test failure since #42 was merged, but was not a problem introduced by this PR.
Also extracted parsing of JSXSpreadChild to own parse function.
cc @kittens @calebmer