Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rerendering map issues #159

Merged
merged 18 commits into from
Mar 22, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add cleanup started mmp observable clean
  • Loading branch information
JannikStreek committed Mar 21, 2023
commit eb82199be6420c13744587b9f470c6e5bc55ee6f
4 changes: 4 additions & 0 deletions teammapper-frontend/mmp/src/map/handlers/events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ export default class Events {
this.dispatcher.on(Event[event], callback as any)
}

public removeAll = () => {
// TODO
}

}

export enum Event {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export class MapComponent implements OnDestroy {
}

ngOnDestroy() {
this.mmpService.remove()
this.mapSyncServiceSubscription.unsubscribe()
}
}