fix: fixed possible memory leak code (#1190)

b-editor · Dec 5, 2024 · 4723392 · 4723392
1 parent 2108b57
commit 4723392
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/Beutl.Engine/Graphics/Rendering/RenderLayer.cs b/src/Beutl.Engine/Graphics/Rendering/RenderLayer.cs
@@ -139,7 +139,7 @@ void AcceptsAll(IGraphicNode node)
                         supportCache.Accepts(cache);
                         if (cache.IsCached
                             && !(cache.CanCacheBoundary()
-                            && cacheContext.CanCacheRecursiveChildrenOnly(node)))
+                                 && cacheContext.CanCacheRecursiveChildrenOnly(node)))
                         {
                             cache.Invalidate();
                         }
@@ -171,7 +171,15 @@ public void Dispose()
         }
 
         _cache.Clear();
-        _currentFrame?.Clear();
+        if (_currentFrame != null)
+        {
+            foreach (Entry item in _currentFrame)
+            {
+                item.Dispose();
+            }
+
+            _currentFrame.Clear();
+        }
     }
 
     public Drawable? HitTest(Point point)

diff --git a/src/Beutl.Engine/Graphics/Rendering/Renderer.cs b/src/Beutl.Engine/Graphics/Rendering/Renderer.cs
@@ -66,6 +66,7 @@ public void Dispose()
             OnDispose(true);
             _immediateCanvas.Dispose();
             _cacheContext.Dispose();
+            RenderScene.Dispose();
             GC.SuppressFinalize(this);
 
             IsDisposed = true;

diff --git a/src/Beutl/ViewModels/PlayerViewModel.cs b/src/Beutl/ViewModels/PlayerViewModel.cs
@@ -680,6 +680,7 @@ public void Dispose()
         AfterRendered.Dispose();
         PreviewInvalidated = null;
         Scene = null!;
+        PreviewImage.Value = null!;
         _logger.LogInformation("Disposed PlayerViewModel. ({SceneId})", _editViewModel.SceneId);
     }