Fix errors on switching dimensions #2126
Annotations
8 warnings
|
very complex type used. Consider factoring parts into `type` definitions:
azalea-client/src/test_simulation.rs#L106
warning: very complex type used. Consider factoring parts into `type` definitions
--> azalea-client/src/test_simulation.rs:106:6
|
106 | ) -> (
| ______^
107 | | LocalPlayerBundle,
108 | | mpsc::UnboundedReceiver<Box<[u8]>>,
109 | | Arc<Mutex<Vec<Box<[u8]>>>>,
110 | | tokio::runtime::Runtime,
111 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
useless conversion to the same type: `std::boxed::Box<[u8]>`:
azalea-client/src/test_simulation.rs#L78
warning: useless conversion to the same type: `std::boxed::Box<[u8]>`
--> azalea-client/src/test_simulation.rs:78:48
|
78 | self.incoming_packet_queue.lock().push(buf.into());
| ^^^^^^^^^^ help: consider removing `.into()`: `buf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
you seem to be trying to use `match` for an equality check. Consider using `if`:
azalea-client/src/test_simulation.rs#L59
warning: you seem to be trying to use `match` for an equality check. Consider using `if`
--> azalea-client/src/test_simulation.rs:59:9
|
59 | / match initial_connection_protocol {
60 | | ConnectionProtocol::Configuration => {
61 | | app.world_mut().entity_mut(entity).insert(InConfigState);
62 | | tick_app(&mut app);
63 | | }
64 | | _ => {}
65 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
59 ~ if initial_connection_protocol == ConnectionProtocol::Configuration {
60 + app.world_mut().entity_mut(entity).insert(InConfigState);
61 + tick_app(&mut app);
62 + }
|
|
|
the following explicit lifetimes could be elided: 'a:
azalea-core/src/data_registry.rs#L27
warning: the following explicit lifetimes could be elided: 'a
--> azalea-core/src/data_registry.rs:27:32
|
27 | fn resolve_and_deserialize<'a, T: simdnbt::Deserialize>(
| ^^
28 | &self,
29 | registries: &'a RegistryHolder,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
27 ~ fn resolve_and_deserialize<T: simdnbt::Deserialize>(
28 | &self,
29 ~ registries: &RegistryHolder,
|
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|