feat: add stats service #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceb8a65 to
ae63812
Compare
felixoff
reviewed
Apr 20, 2024
|
|
||
| private String app; | ||
|
|
||
| private String uri; |
There was a problem hiding this comment.
Вместо множественных private лучше использовать @FieldDefaults
| } | ||
|
|
||
| @Test | ||
| @SneakyThrows |
There was a problem hiding this comment.
SneakyTrows нужно использовать очень осторожно
There was a problem hiding this comment.
Удалил, но мне IDEA сама подсказывает это в тестах применять. В основном коде же я это не использую
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.