Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed todos from task list for classes Match and RankingRepository #198

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Completed todos from task list for classes Match and RankingRepository #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions League/Controllers/Match.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,6 @@ public async Task<IActionResult> EditFixture([FromForm] EditFixtureViewModel mod

ModelState.Clear();

// Todo: This business logic should rather go into settings
//_tenantContext.TournamentContext.FixtureRuleSet.PlannedMatchTimeMustStayInCurrentLegBoundaries = model.Tournament.IsPlanningMode;

if (!await model.ValidateAsync(
new FixtureValidator(match, (_tenantContext, _timeZoneConverter, model.PlannedMatch), DateTime.UtcNow),
ModelState))
Expand Down Expand Up @@ -772,8 +769,6 @@ private void SendFixtureNotification(long matchId)

private void SendResultNotification(in MatchEntity match, bool isResultRemoved)
{
// Todo: Should we check whether an existing result was changed?

var smt = _sendMailTask.CreateNewInstance();
smt.SetMessageCreator(new ResultEnteredCreator
{
Expand Down
1 change: 0 additions & 1 deletion TournamentManager/TournamentManager/Data/RankingRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public virtual async Task ReplaceAsync(RankingList rankingList, long roundId, Ca

try
{
// Todo: TournamentId is defined via the Round - remove TournamentId from the Ranking table. View RankingList does not depend on TournamentId already.
var tournamentId = await GetTournamentIdOfRoundAsync(roundId, cancellationToken);

// Fetch existing ranking entities for the round for deletion
Expand Down