Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Site.ModalForm.js to work on Safari browsers #124

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Nov 19, 2023

  • Check the argument for the 'click' event for possible null
  • Make sure the form is instanceof HTMLFormElement
  • Add Polyfill for Element.closest (for browsers not supporting it)

* Check the argument for the 'click' event for possible null
* Make sure the form is instanceof HTMLFormElement
* Add Polyfill for Element.closest (for browsers not supporting it)
@axunonb axunonb merged commit b05bb7c into main Nov 19, 2023
3 checks passed
@axunonb axunonb deleted the pr/site-modal-form-safari branch November 19, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant