Skip to content

Commit

Permalink
Breaking: Make MatchScheduler.ScheduleFixturesForRound(...) private (#…
Browse files Browse the repository at this point in the history
…183)

Reasoning: There are no plausibility checks for the RoundEntity parameter, and there is no advantage to use this method directly instead of MatchScheduler.ScheduleFixturesForTournament(...)
  • Loading branch information
axunonb authored Sep 9, 2024
1 parent dd429d4 commit 8ac1b25
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion TournamentManager/TournamentManager/Plan/MatchScheduler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ private async Task GenerateAvailableMatchDatesAsync(MatchDateClearOption clearMa
/// assigns optimized match dates and stores the matches to
/// the persistent storage.
/// </summary>
/// <param name="keepExisting">If <see langword="true"/>, all existing fixtures remain unchanged.
/// Only fixtures for newly added teams will be created.
/// </param>
/// <param name="cancellationToken"></param>
public async Task ScheduleFixturesForTournament(bool keepExisting, CancellationToken cancellationToken)
{
await LoadEntitiesAsync(cancellationToken);
Expand All @@ -74,7 +78,11 @@ public async Task ScheduleFixturesForTournament(bool keepExisting, CancellationT
/// assigns optimized match dates and stores the matches to
/// the persistent storage.
/// </summary>
public async Task ScheduleFixturesForRound(RoundEntity round, bool keepExisting,
/// <remarks>Keep this method private.</remarks>
/// <param name="round">The round where fixtures will be created.</param>
/// <param name="keepExisting">If <see langword="true"/>, all existing fixtures remain unchanged. Only fixtures for newly added teams will be created.</param>
/// <param name="cancellationToken"></param>
private async Task ScheduleFixturesForRound(RoundEntity round, bool keepExisting,
CancellationToken cancellationToken)
{
await LoadEntitiesAsync(cancellationToken);
Expand Down

0 comments on commit 8ac1b25

Please sign in to comment.