Merge pull request #12 from axone-protocol/feat/auth-http-handler

👤 Implements auth handler

auth/jwt/http.go

@@ -3,6 +3,7 @@ package jwt
 import (
 	"context"
 	"errors"
+	"fmt"
 	"io"
 	"net/http"
 
@@ -12,23 +13,27 @@ import (
 func (f *Factory) HTTPAuthHandler(proxy auth.Proxy) http.Handler {
 	return http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {
 		credential, err := io.ReadAll(request.Body)
-		if err != nil { //nolint:staticcheck,revive
-			// ...
+		if err != nil {
+			http.Error(writer, fmt.Errorf("failed to read request body credential: %w", err).Error(), http.StatusInternalServerError)
+			return
 		}
 
 		id, err := proxy.Authenticate(context.Background(), credential)
-		if err != nil { //nolint:staticcheck,revive
-			// ...
+		if err != nil {
+			http.Error(writer, fmt.Errorf("failed to authenticate: %w", err).Error(), http.StatusUnauthorized)
+			return
 		}
 
 		token, err := f.IssueJWT(id)
-		if err != nil { //nolint:staticcheck,revive
-			// ...
+		if err != nil {
+			http.Error(writer, fmt.Errorf("failed to issue JWT: %w", err).Error(), http.StatusInternalServerError)
+			return
 		}
 
 		writer.Header().Set("Content-Type", "application/json")
-		if _, err := writer.Write([]byte(token)); err != nil { //nolint:staticcheck,revive
-			// ...
+		if _, err := writer.Write([]byte(token)); err != nil {
+			http.Error(writer, fmt.Errorf("failed to write response: %w", err).Error(), http.StatusInternalServerError)
+			return
 		}
 	})
 }
@@ -37,8 +42,7 @@ func (f *Factory) VerifyHTTPMiddleware(next auth.AuthenticatedHandler) http.Hand
 	return http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {
 		id, err := f.VerifyHTTPRequest(request)
 		if err != nil {
-			writer.WriteHeader(http.StatusUnauthorized)
-			writer.Write([]byte(err.Error())) //nolint:errcheck
+			http.Error(writer, err.Error(), http.StatusUnauthorized)
 			return
 		}
 

auth/jwt/http_test.go

@@ -0,0 +1,155 @@
+package jwt_test
+
+import (
+	"bytes"
+	"context"
+	"fmt"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+	"time"
+
+	"github.com/axone-protocol/axone-sdk/auth"
+	"github.com/axone-protocol/axone-sdk/auth/jwt"
+	"github.com/axone-protocol/axone-sdk/testutil"
+	. "github.com/smartystreets/goconvey/convey"
+	"go.uber.org/mock/gomock"
+)
+
+func TestFactory_HTTPAuthHandler(t *testing.T) {
+	tests := []struct {
+		name                 string
+		body                 []byte
+		identity             *auth.Identity
+		expectedStatus       int
+		expectedBodyContains string
+	}{
+		{
+			name: "valid request",
+			body: []byte(`valid`),
+			identity: &auth.Identity{
+				DID:               "did:key:zQ3shpoUHzwcgdt2gxjqHHnJnNkBVd4uX3ZBhmPiM7J93yqCr",
+				AuthorizedActions: nil,
+			},
+			expectedStatus:       200,
+			expectedBodyContains: "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9",
+		},
+		{
+			name:                 "invalid authentication",
+			body:                 []byte(`invalid`),
+			identity:             nil,
+			expectedStatus:       401,
+			expectedBodyContains: "failed to authenticate: authentication failed",
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			Convey("Given a JWT factory and mocked auth proxy on mocked http server", t, func() {
+				factory := jwt.NewFactory(nil, "issuer", 5*time.Second)
+
+				controller := gomock.NewController(t)
+				defer controller.Finish()
+
+				mockAuthProxy := testutil.NewMockProxy(controller)
+				handler := factory.HTTPAuthHandler(mockAuthProxy)
+
+				mockAuthProxy.EXPECT().Authenticate(gomock.Any(), gomock.Any()).
+					DoAndReturn(func(_ context.Context, body []byte) (interface{}, error) {
+						if body != nil && string(body) == "valid" {
+							return test.identity, nil
+						}
+						return nil, fmt.Errorf("authentication failed")
+					}).
+					Times(1)
+
+				Convey("When the HTTPAuthHandler is called", func() {
+					req, err := http.NewRequest("POST", "/", bytes.NewBuffer(test.body)) //nolint:noctx
+					So(err, ShouldBeNil)
+
+					recorder := httptest.NewRecorder()
+					handler.ServeHTTP(recorder, req)
+
+					Convey("Then the response should match the expected status and body", func() {
+						So(recorder.Code, ShouldEqual, test.expectedStatus)
+						So(recorder.Body.String(), ShouldContainSubstring, test.expectedBodyContains)
+					})
+				})
+			})
+		})
+	}
+}
+
+func TestFactory_VerifyHTTPMiddleware(t *testing.T) {
+	// Generate a valid token for testing purpose
+	token, err := jwt.NewFactory([]byte("secret"), "issuer", 5*time.Second).IssueJWT(&auth.Identity{
+		DID:               "did:key:zQ3shpoUHzwcgdt2gxjqHHnJnNkBVd4uX3ZBhmPiM7J93yqCr",
+		AuthorizedActions: nil,
+	})
+	if err != nil {
+		t.Fatalf("failed to issue a test jwt token: %v", err)
+	}
+
+	tests := []struct {
+		name                 string
+		authHeader           string
+		expectedIdentity     *auth.Identity
+		expectedStatus       int
+		expectedBodyContains string
+	}{
+		{
+			name:       "valid token",
+			authHeader: fmt.Sprintf("Bearer %s", token),
+			expectedIdentity: &auth.Identity{
+				DID: "did:key:zQ3shpoUHzwcgdt2gxjqHHnJnNkBVd4uX3ZBhmPiM7J93yqCr",
+			},
+			expectedStatus:       200,
+			expectedBodyContains: "success",
+		},
+		{
+			name:                 "invalid token",
+			authHeader:           "Bearer invalid_token",
+			expectedStatus:       401,
+			expectedBodyContains: "token contains an invalid number of segments",
+		},
+		{
+			name:                 "missing token",
+			authHeader:           "",
+			expectedStatus:       401,
+			expectedBodyContains: "couldn't find bearer token",
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			Convey("Given a JWT factory and mocked authenticated handler", t, func() {
+				factory := jwt.NewFactory([]byte("secret"), "issuer", 5*time.Second)
+
+				mockHandler := func(id *auth.Identity, w http.ResponseWriter, _ *http.Request) {
+					So(id, ShouldResemble, test.expectedIdentity)
+					w.WriteHeader(http.StatusOK)
+					_, err := w.Write([]byte("success"))
+					So(err, ShouldBeNil)
+				}
+
+				middleware := factory.VerifyHTTPMiddleware(mockHandler)
+
+				Convey("When the VerifyHTTPMiddleware is called", func() {
+					req, err := http.NewRequest("GET", "/", nil) //nolint:noctx
+					So(err, ShouldBeNil)
+					if test.authHeader != "" {
+						req.Header.Set("Authorization", test.authHeader)
+					}
+
+					recorder := httptest.NewRecorder()
+					middleware.ServeHTTP(recorder, req)
+
+					Convey("Then the response should match the expected status and body", func() {
+						So(recorder.Code, ShouldEqual, test.expectedStatus)
+						So(recorder.Body.String(), ShouldContainSubstring, test.expectedBodyContains)
+					})
+				})
+			})
+		})
+	}
+}