Bump Tomcat (10), JDK (17), and ERDDAP (2.22) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abkfenris
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
I did a quick and dirty test of building it locally, and that works, but I haven't tried to exercise it any.
Edit: We could start pushing all commits to the Github Container Registry, then we could test them more thoroughly (and give anyone who wants to live on the bleeding edge access), and then promote releases to Docker Hub.
Comment on lines
36
to
39
| axiom/docker-erddap | ||
| tags: | | ||
| type=raw,value=${{ matrix.tag }},prefix=latest- | ||
| type=raw,value=latest,enable=${{ matrix.tag == 'jdk8-openjdk' }} | ||
| type=raw,value=${{ github.event.release.tag_name }},enable=${{ matrix.tag == 'jdk8-openjdk' && github.event_name == 'release' && github.event.action == 'published' }} | ||
| type=raw,value=${{ github.event.release.tag_name }},suffix=-${{ matrix.tag }},enable=${{ github.event_name == 'release' && github.event.action == 'published' }} |
There was a problem hiding this comment.
I think since these are already referenced as an output, we could use a job level output to share them across jobs rather than re-defining them, but that's not necessary to land this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.