blockchain: fix inconsistent reorg behavior #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65df573 to
c988786
Compare
If the chain is reorganized because the newly submit block has higher justified block number, it can be reverted back to the old chain prior to reorg because the old blocks cause ErrKnownBlock during insertion via the insertChain method, which invokes writeKnownBlock to set the old chain as the canonical chain again.
…face When testing, we may need to create the standalone consortium-v2 engine so we need to make it fully implement FastFinalityPoSA interface.
When generating Consortium blocks, we need to modify the block after FinalizeAndAssemble to change the block signature in header's extra data. New function GenerateConsortiumChain adds a new parameter so the caller can pass a function to modify block after FinalizeAndAssemble. Besides, the fake chain reader also needs to return correct block header to be used by consensus engine in FinalizeAndAssemble.
c988786 to
cd2adc8
Compare
minh-bq
approved these changes
Jan 17, 2024
minh-bq
added a commit
to minh-bq/ronin
that referenced
this pull request
Feb 20, 2024
* blockchain: fix inconsistent reorg behavior If the chain is reorganized because the newly submit block has higher justified block number, it can be reverted back to the old chain prior to reorg because the old blocks cause ErrKnownBlock during insertion via the insertChain method, which invokes writeKnownBlock to set the old chain as the canonical chain again. * consortium-v2: make the engine fully implement FastFinalityPoSA interface When testing, we may need to create the standalone consortium-v2 engine so we need to make it fully implement FastFinalityPoSA interface. * chain_makers: add GenerateConsortiumChain to genernate Consortium blocks When generating Consortium blocks, we need to modify the block after FinalizeAndAssemble to change the block signature in header's extra data. New function GenerateConsortiumChain adds a new parameter so the caller can pass a function to modify block after FinalizeAndAssemble. Besides, the fake chain reader also needs to return correct block header to be used by consensus engine in FinalizeAndAssemble. * consortium-v2: add unit test for known block reorg case --------- Co-authored-by: Bui Quang Minh <minh.bui@skymavis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the chain is reorganized because the newly submit block has higher justified block number, it can be reverted back to the old chain prior to reorg because the old blocks cause
ErrKnownBlockduring insertion via theinsertChainmethod, which invokeswriteKnownBlockto set the old chain as the canonical chain again.